Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for configuring the Redis database using spring.data.redis.url #43813

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for configuring the Redis database using spring.data.redis.url #43813

wants to merge 1 commit into from
+27 −15

Conversation

quaff
Copy link
Contributor

@quaff quaff commented Jan 14, 2025

Fix GH-43810

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 14, 2025
@wilkinsona wilkinsona changed the title Parse redis database from url if present Add support for configuring the Redis database using spring.data.redis.url Jan 15, 2025
@wilkinsona wilkinsona added this to the 3.5.x milestone Jan 15, 2025
@wilkinsona wilkinsona added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 15, 2025
@wilkinsona wilkinsona self-assigned this Jan 15, 2025
@wilkinsona wilkinsona mentioned this pull request Jan 15, 2025
Closed
@wilkinsona
Copy link
Member

Thanks for the PR, @quaff. A couple of things:

  1. Could you please rebase this on top of the head of main to address the conflicts?
  2. Did you consider making getDatabase() of the Sentinel instance returned by PropertiesRedisConnectionDetails use the database from the URL? I am in two minds as to whether that's the right thing to do.

@wilkinsona wilkinsona added the status: waiting-for-feedback We need additional information before we can continue label Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wilkinsona wilkinsona

Labels
status: waiting-for-feedback We need additional information before we can continue type: enhancement A general enhancement
Projects
None yet
Milestone
3.5.x
Development

Successfully merging this pull request may close these issues.

Add support for configuring the Redis database using spring.data.redis.url
3 participants
@quaff @wilkinsona @spring-projects-issues