Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply tax on discounted price #37

Open
wants to merge 1 commit into
base: 3-0-stable
Choose a base branch
from

Conversation

cyu
Copy link

@cyu cyu commented Jan 11, 2017

This patch is for the 3-0-stable, but the commit applies cleanly on master as well. Please let me know if I need to prepare this PR differently

@damianlegawiec
Copy link
Contributor

Hi @cyu - could you also do a PR against master? Thanks!

@cyu
Copy link
Author

cyu commented Jan 12, 2017

@damianlegawiec #38 It looks like spree master has a pre_tax_amount field that's more appropriate to use.

@cyu cyu force-pushed the tax-on-discounted branch from 9c6607d to e46a06d Compare January 19, 2017 19:55
@cyu cyu force-pushed the tax-on-discounted branch from e46a06d to 842f377 Compare January 19, 2017 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants