Targeting .NET 8 #196
Closed
Targeting .NET 8 #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brodny May I ask why you abandoned this PR? Is it because you didn't receive a response? |
|
I am not sure of what you are making reference to here ?
John Boyd 😊
…On Tue, Sep 3, 2024, 2:02 AM fl3pp ***@***.***> wrote:
@brodny <https://github.com/brodny> May I ask why you abandoned this PR?
Is it because you didn't receive a response?
—
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYXHWL4EBLCTIIN2H3IEQLZUVGHDAVCNFSM6AAAAABGNZI62WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVGY3DOOJUHA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
@fl3pp No, not quite, I was doing it just for my own amusement ;) I created PR by accident before I had a chance to properly test it, and now I cannot dedicate the time it needs because of personal matters. I also had the ambition to enable nullable reference types for the project but same issues as above. Sorry about that but if you need .NET8 support, feel free to take this PR and move on, I won't mind ;) |
|
Thanks, 😊 that is fine 🙂 All is good 😊
…On Tue, Sep 3, 2024, 3:12 AM Łukasz Brodny ***@***.***> wrote:
@fl3pp <https://github.com/fl3pp> No, not quite, I was doing it just for
my own amusement ;) I created PR by accident before I had a chance to
properly test it, and now I cannot dedicate the time it needs because of
personal matters. I also had the ambition to enable nullable reference
types for the project but same issues as above. Sorry about that but if you
need .NET8 support, feel free to take this PR and move on, I won't mind ;)
—
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYXHWKIQML653HD6YI2XHTZUVOPFAVCNFSM6AAAAABGNZI62WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRVG43DMMJYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Sorry for the confusion! I was reading about the issue #194 and wondered why this PR was closed. Seems like I inferred too much here. Anyway, thanks to both of you for the quick replies |
|
No worries. 👍
…On Tue, Sep 3, 2024, 1:21 PM fl3pp ***@***.***> wrote:
Sorry for the confusion! I was reading about the issue #194
<#194> and wondered why this PR
was closed. Seems like I inferred too much.
Anyway, thanks to both of you for the quick replies
—
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAYXHWNIX6BKG52YPAVGJS3ZUXVZ7AVCNFSM6AAAAABGNZI62WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMRXGA2TGMBUGY>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.