Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose multi-query in StringIndex #58

Merged
merged 3 commits into from
Mar 20, 2024
Merged

expose multi-query in StringIndex #58

merged 3 commits into from
Mar 20, 2024

Conversation

dylanrb123
Copy link
Contributor

Allow querying for multiple target vectors in parallel from StringIndex

Copy link
Member

@psobot psobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some small nits.

Copy link
Contributor

@markkohdev markkohdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good except for a clarifying comment
🌵 🍰 🤙

@dylanrb123 dylanrb123 merged commit 4d8ada5 into main Mar 20, 2024
53 checks passed
@dylanrb123 dylanrb123 deleted the expose-multi-query branch March 20, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants