Resizing of index. #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samek thanks for this! Can you try rebasing this branch on |
|
@markkohdev done. |
markkohdev
requested changes
Mar 22, 2024
There was a problem hiding this comment.
@samek this looks great but left one small comment on the test naming
java/src/test/java/com/spotify/voyager/jni/StringIndexTest.java
Outdated
Show resolved
Hide resolved
markkohdev
approved these changes
Mar 26, 2024
|
@samek this change will be released in the next version. Let us know if this is urgent though and we can cut a release specifically for this change |
|
@markkohdev it's fine for the next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added resizing of index which was missing in java.