Ensure that native C++ index object doesn't get destroyed while Java threads are using it. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…threads are still using it.
|
No need, @samek - if your PR gets merged first, I'll update this one (as it'll fail to compile), and vice versa. |
psobot
requested review from
markkohdev and
dylanrb123
and removed request for
dylanrb123
|
@psobot is there a good way to test this to ensure that it's working as expected? |
|
@markkohdev test added! |
dylanrb123
approved these changes
Mar 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a somewhat clever solution to give us a bit more thread safety around our JNI bindings to Voyager's C++ code: instead of storing a raw pointer on the Java object, we now store a pointer to a
std::shared_ptr, which gives us thread-safe destruction and ensures that the underlying C++ object doesn't get destroyed while another Java thread might still be using it.