Use metrics size, not in bytes for pubsub limit fix (#247)

* Use metrics size, not in bytes for pubsub limit fix * Change log to warn level
spotify · Feb 25, 2021 · 625df74 · 625df74
1 parent f7c592e
commit 625df74
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/modules/pubsub/src/main/java/com/spotify/ffwd/pubsub/PubsubPluginSink.java b/modules/pubsub/src/main/java/com/spotify/ffwd/pubsub/PubsubPluginSink.java
@@ -123,9 +123,9 @@ public AsyncFuture<Void> sendMetrics(Collection<Metric> metrics) {
       final ByteString m = ByteString.copyFrom(serializer.serialize(metrics, writeCache));
 
       if (m.size() > MAX_BATCH_SIZE_BYTES) {
-        logger.debug("Above byte limit, resizing batch");
+        logger.warn("Above byte limit, resizing batch");
         int times = (int)Math.ceil(m.size()/MAX_BATCH_SIZE_BYTES);
-        List<List<Metric>> collections = Lists.partition(new ArrayList<>(metrics), m.size()/times);
+        List<List<Metric>> collections = Lists.partition(new ArrayList<>(metrics), metrics.size()/times);
         for (List<Metric> l: collections) {
           final ByteString mResize = ByteString.copyFrom(serializer.serialize(l, writeCache));
           publishPubSub(mResize);