This repository has been archived by the owner on Mar 21, 2022. It is now read-only.
Respect the tag specfied in the image name in removeImage #225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #113 added support for multiple image tags for image removal, but that simple at a glance modification introduced a few problems:
(2) is not observable when running the tests, because the way plugins are configured is different for real projects. You can verify that by executing pom-removeImage.xml as standalone (mvn docker:removeImage -f pom-removeImage.xml, add -X to see how the configuration is resolved). I changed the plugin version to 0.4.8-SNAPSHOT and removed the dockerHost parameter to get it to run this way.
Each commit in this PR addresses one of the aforementioned issues.