-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DomainTools Iris Investigate: Feature - Implement playbook monitoring feature #33
DomainTools Iris Investigate: Feature - Implement playbook monitoring feature #33
Conversation
DomainTools Iris Investigate: Bugfix/Feature: Release bugfixes and new features for v.1.4.0
DomainTools Iris Investigate: Code style update - Fix linting issues
…ed_with_all` for pivot action.
Downgrade `urllib3` and add support parameters `tagged_with_any` and `tagged_with_all` for pivot action
…spaces-for-tags Fix issue on handling valid spaces on tags.
…s/domaintoolsiris into ID-1986-on-poll-functionality
…oll functionality
ID-1986-on-poll-functionality
…ybook format with 1440 mins default interval
…ntent and unreleased.md
…ools/domaintoolsiris into ID-1986-update-for-1.5.0-release
…ools/domaintoolsiris into ID-1986-update-for-1.5.0-release
Validation: Fix Static Tests results
@briluza Static Tests results for commit 4c1dccf - https://drive.google.com/file/d/1WffLSCVDZNE3e4XT0op0RLaJUzYHopiC/view?usp=drivesdk |
@briluza Compile Tests results for commit 4c1dccf - https://drive.google.com/file/d/1u8FISyqFzd5oBWARPY1urUPn_HEQ4Vb7/view?usp=drivesdk |
Add missing required data_path
@briluza Static Tests results for commit 2936509 - https://drive.google.com/file/d/1SwjYCQaEwQ7o5O0iyyJO0ds5oeXCokYy/view?usp=drivesdk |
@briluza Compile Tests results for commit 2936509 - https://drive.google.com/file/d/1l1EbRnm7N7b5_E1ZtYi3fO_FIedZnjSw/view?usp=drivesdk |
…ools/domaintoolsiris into ID-1986-update-for-1.5.0-release
Bump version of min phantom version to 6.1.1
@briluza Static Tests results for commit d6e600f - https://drive.google.com/file/d/1gUQmq1dSYwYi-LtyTO2I8etdDtXQWBZF/view?usp=drivesdk |
@briluza Compile Tests results for commit d6e600f - https://drive.google.com/file/d/1IKRRtYtMeglEd_IPr6sV6XnTSNbIvsuW/view?usp=drivesdk |
Change order of new actions in domaintoolsiris.json
@briluza Static Tests results for commit 75c1f7d - https://drive.google.com/file/d/1JxfJKAsowpW_ym3306XCCO72sYX4_Zwd/view?usp=drivesdk |
@briluza Compile Tests results for commit 75c1f7d - https://drive.google.com/file/d/1xNyXS-nJvGsaRNSAVGHriPa8CAtrd074/view?usp=drivesdk |
Hello @briluza, Could you please grant the right access to me for performing the commit and push operations? |
Hi @mmomin-crest, I've given you write access to this repo. You should have permission for commit and push operations. Please let us know if you have any trouble with that. Thank you! |
Thanks @wesleya, Stil I am facing issue while pushing the changes to branch '1.5.0'. Can you please check once. FYI - As per our practice, I have removed the requests and their sub dependencies. Now we only use requests and their dependencies from Splunk SOAR Platform. |
@mmomin-crest github is showing your access to the repo as |
@mmomin-crest Static Tests results for commit 65fd55b - https://drive.google.com/file/d/1eWJVOGtjc7rF6jj-nAaMRGfQM1ls2ZtR/view?usp=drivesdk |
@mmomin-crest Compile Tests results for commit 65fd55b - https://drive.google.com/file/d/1tip7X0ZzkpXrfqK4YvD94yc_0Whcxs8Q/view?usp=drivesdk |
Okay, I got the invite and accepted it. Now, able to push the changes. |
c8e42b8
into
splunk-soar-connectors:next
Thanks for your help with this, @mmomin-crest ! Seeing as we seem to face the linting test failures on each of the past few submissions we've made to this repo, is there anything we should be doing differently, or anything to be fixed in the automation so we don't have to get you involved on each push we make? (you can also reach the team here directly at [email protected]) |
Please ensure your pull request (PR) adheres to the following guidelines:
Pull Request Checklist
Please check if your PR fulfills the following requirements:
<App Name>: <PR Type> - <PR Description>
next
branch of the forked repo. Create separate feature branch for raising the PR.Pull Request Type
Please check the type of change your PR introduces:
Security Considerations (REQUIRED)
please document them in the
manual_readme_content.md
.manual_readme_content.md
all methods (eg, OAuth) used to authenticatewith the service that the connector is integrating with.
manual_readme_content.md
.the Vault API.
nosemgrep
?If yes, please provide justification in an additional comment next to the ignored code.
Release Notes (REQUIRED)
What is the current behavior? (OPTIONAL)
What is the new behavior? (OPTIONAL)
Other information (OPTIONAL)
Pay close attention to (OPTIONAL)
Screenshots (if relevant)
Thanks for contributing!