Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DomainTools Iris Investigate: Feature - Implement playbook monitoring feature #33

Merged
merged 59 commits into from
Feb 12, 2024

Conversation

briluza
Copy link
Contributor

@briluza briluza commented Jan 2, 2024

Please ensure your pull request (PR) adheres to the following guidelines:

  • Please refer to our contributing documentation for any questions on submitting a pull request, link: Contribution Guide

Pull Request Checklist

Please check if your PR fulfills the following requirements:

  • Testing of all the changes has been performed (for bug fixes / features)
  • The manual_readme_content.md has been reviewed and added / updated if needed (for bug fixes / features)
  • Use the following format for the PR description: <App Name>: <PR Type> - <PR Description>
  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.
  • Verify all checks are passing.
  • Do NOT use the next branch of the forked repo. Create separate feature branch for raising the PR.
  • Do NOT submit updates to dependencies unless it fixes an issue.

Pull Request Type

Please check the type of change your PR introduces:

  • New App
  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation
  • Other (please describe):

Security Considerations (REQUIRED)

  • If you are exposing any endpoints using a REST handler,
    please document them in the manual_readme_content.md.
  • If this is a new connector or you are adding new actions
    • Please document in the manual_readme_content.md all methods (eg, OAuth) used to authenticate
      with the service that the connector is integrating with.
    • If any actions are unable to run on SOAR Cloud, please document this in the manual_readme_content.md.
  • Are you introducing any new cryptography modules? If yes, please elaborate their purpose:
  • Are you are accessing the file system? If yes, please verify that you are only accessing paths returned through
    the Vault API.
  • Are you are marking code to be ignored by Semgrep with nosemgrep?
    If yes, please provide justification in an additional comment next to the ignored code.

Release Notes (REQUIRED)

  • Provide release notes as part of the PR submission which describe high level points about the changes for the upcoming GA release.

What is the current behavior? (OPTIONAL)

  • Describe the current behavior that you are modifying.

What is the new behavior? (OPTIONAL)

  • Describe the behavior or changes that are being added by this PR.

Other information (OPTIONAL)

  • Any other information that is important to this PR such as screenshots of how the component looks before and after the change.

Pay close attention to (OPTIONAL)

  • Any specific code change or test case points which must be addressed/reviewed at the time of GA release.

Screenshots (if relevant)

image

Thanks for contributing!

dnunes-domaintools and others added 30 commits July 12, 2023 10:15
DomainTools Iris Investigate:  Bugfix/Feature: Release bugfixes and new features for v.1.4.0
DomainTools Iris Investigate: Code style update - Fix linting issues
Downgrade `urllib3` and add support parameters `tagged_with_any` and `tagged_with_all` for pivot action
…spaces-for-tags

Fix issue on handling valid spaces on tags.
…s/domaintoolsiris into ID-1986-on-poll-functionality
…ybook format with 1440 mins default interval
…ools/domaintoolsiris into ID-1986-update-for-1.5.0-release
…ools/domaintoolsiris into ID-1986-update-for-1.5.0-release
@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@mmomin-crest
Copy link
Contributor

Hello @briluza, Could you please grant the right access to me for performing the commit and push operations?

@wesleya
Copy link
Collaborator

wesleya commented Feb 7, 2024

Hi @mmomin-crest, I've given you write access to this repo. You should have permission for commit and push operations. Please let us know if you have any trouble with that. Thank you!

@mmomin-crest
Copy link
Contributor

mmomin-crest commented Feb 8, 2024

Hi @mmomin-crest, I've given you write access to this repo. You should have permission for commit and push operations. Please let us know if you have any trouble with that. Thank you!

Thanks @wesleya, Stil I am facing issue while pushing the changes to branch '1.5.0'. Can you please check once.

image

FYI - As per our practice, I have removed the requests and their sub dependencies. Now we only use requests and their dependencies from Splunk SOAR Platform.

@wesleya
Copy link
Collaborator

wesleya commented Feb 8, 2024

@mmomin-crest github is showing your access to the repo as Pending Invite - Awaiting mmomin-crest’s response. Maybe the last invite was expired or caught in junk so I've gone ahead and re-added you. Let me know if you don't see the invite, thank you!

@splunk-soar-connectors-bot
Copy link
Collaborator

@splunk-soar-connectors-bot
Copy link
Collaborator

@mmomin-crest
Copy link
Contributor

@mmomin-crest github is showing your access to the repo as Pending Invite - Awaiting mmomin-crest’s response. Maybe the last invite was expired or caught in junk so I've gone ahead and re-added you. Let me know if you don't see the invite, thank you!

Okay, I got the invite and accepted it. Now, able to push the changes.

@dnunes-domaintools dnunes-domaintools merged commit c8e42b8 into splunk-soar-connectors:next Feb 12, 2024
4 checks passed
@dnunes-domaintools
Copy link
Collaborator

Thanks for your help with this, @mmomin-crest ! Seeing as we seem to face the linting test failures on each of the past few submissions we've made to this repo, is there anything we should be doing differently, or anything to be fixed in the automation so we don't have to get you involved on each push we make? (you can also reach the team here directly at [email protected])

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants