ldap implementation

[vincentDcmps]

Hi like request in #181 I will try to work on LDAP integration I create this pull request for following

[codecov]

Codecov Report

Attention: Patch coverage is 79.71014% with 14 lines in your changes missing coverage. Please review.

Project coverage is 85.77%. Comparing base (24a796e) to head (f6334d5).

Files with missing lines	Patch %	Lines
supysonic/managers/ldap.py	70.21%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   85.90%   85.77%   -0.13%     
==========================================
  Files          47       48       +1     
  Lines        3902     3965      +63     
==========================================
+ Hits         3352     3401      +49     
- Misses        550      564      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[vincentDcmps]

I take inspiration from #250 to implement LDAP
still need:

• test
• documentation

[vincentDcmps]

Hi I have some issue for write test do you have any idea on how to do a ldap mock?

[spl0k]

I wish there was some kind of embeddable directory for LDAP, kinda like SQLite...

Maybe you can use the unittest.mock library to patch the ldap3 library and use the side effects to return the data you need?

[vincentDcmps]

hello, I have added some test thanks for your advice!!
@spl0k Could you review code and tell me if somebody is not correct.

PS: fail test seem not link with my modification

[spl0k]

Hello.

Sorry I hadn't taken the time to respond yet. This is something I'd like to try with a real LDAP backend but I lack knowledge in the matter. I'll get back to you as soon as I manage to set up a LDAP server.

[vincentDcmps]

Hi if you want try with fast LDAP instalation you could take a look on LLDAP side

[spl0k]

Hello. I actually managed to setup a basic OpenLDAP server some time ago.

I remember noticing uncaught errors if the server wasn't setup properly but I don't recall if it was with your PR or #250.
Then I wasn't satisfied with how the current auth and LDAP are somehow tangled together so I started working some kind of pluggable auth system... and kinda gave up along the way.

[vithyze]

Hi @spl0k @vincentDcmps everything seems to be working fine, I made some little improvements in this PR Looking forward for this to be merged :)

[vithyze]

Also btw I was tired of messing with OpenLDAP just for adding some users and doing authentication so I found this project which might be of interest

[vincentDcmps]

Hi vithyze thanks for your fix, but final decision to include or not these modification need to be made by @spl0k who is the creator/main maintaner of these project.