Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(install): Fixed packer version check for packer installation #1121

Merged
merged 1 commit into from
Nov 22, 2024
Merged

fix(install): Fixed packer version check for packer installation #1121

merged 1 commit into from
Nov 22, 2024

Conversation

ashleykleynhans
Copy link
Contributor

Fixes the following error during post installation of the Rosco debian package:

Unpacking spinnaker-rosco (1.22.0) over (1.21.0) ...
Setting up spinnaker-rosco (1.22.0) ...
/var/lib/dpkg/info/spinnaker-rosco.postinst: 53: Syntax error: redirection unexpected
dpkg: error processing package spinnaker-rosco (--configure):

jasonmcintosh
jasonmcintosh approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<<< SHOULD have worked but this does work.

@jasonmcintosh jasonmcintosh added the ready to merge Approved and ready for merge label Nov 22, 2024
@mergify mergify bot added the auto merged label Nov 22, 2024
@mergify mergify bot merged commit 34a6f29 into spinnaker:master Nov 22, 2024
4 checks passed
@ashleykleynhans
Copy link
Contributor Author

<<< SHOULD have worked but this does work.

Probably didn't work because the post init script is #!/bin/sh and not #!/bin/bash.
When I tested it locally before approving the PR, I tested with bash and not bourne shell so thats probably where the discrepancy came in, apologies for that.

@ashleykleynhans
Copy link
Contributor Author

I just tested and confirmed that <<< works with bash, but not with sh.

@himanhsugusain
Copy link
Contributor

For anyone struggling with local install , just patch /var/lib/dpkg/info/spinnaker-rosco.postinst locally till release.

@jasonmcintosh
Copy link
Member

@Mergifyio backport release-1.36.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 4, 2024 •
edited
Loading

backport release-1.36.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 4, 2024
@ashleykleynhans @mergify
fix(install): Fixed packer version check for packer installation (#1121)
b8a154d 
(cherry picked from commit 34a6f29)
@mergify mergify bot mentioned this pull request Dec 4, 2024
Merged
mergify bot added a commit that referenced this pull request Jan 23, 2025
@mergify @ashleykleynhans @jasonmcintosh
fix(install): Fixed packer version check for packer installation (#1121…
469879d 
…) (#1128)

(cherry picked from commit 34a6f29)

Co-authored-by: Ashley Kleynhans <[email protected]>
Co-authored-by: Jason <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh approved these changes

Assignees
No one assigned
Labels
auto merged ready to merge Approved and ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ashleykleynhans @himanhsugusain @jasonmcintosh