fix(queue): atomicity fix in read_message

spinnaker · Apr 23, 2018 · 9bd389e · 9bd389e
1 parent 7d54a6b
commit 9bd389e
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/keiko-redis/src/main/kotlin/com/netflix/spinnaker/q/redis/RedisQueue.kt b/keiko-redis/src/main/kotlin/com/netflix/spinnaker/q/redis/RedisQueue.kt
@@ -453,7 +453,7 @@ private const val READ_MESSAGE_WITH_LOCK = """
       local i=1
       while (i <= #fingerprints) do
         redis.call("ECHO", "attempting lock on " .. fingerprints[i])
-        if redis.call("SET", locksKey .. ":" .. fingerprints[i], "\uD83D\uDD12", "EX", lockTtlSeconds, "NX") ~= nil then
+        if redis.call("SET", locksKey .. ":" .. fingerprints[i], "\uD83D\uDD12", "EX", lockTtlSeconds, "NX") then
           redis.call("ECHO", "acquired lock on " .. fingerprints[i])
           return fingerprints[i], fingerprints[i+1]
         end