fix(config/test): provide a non-null halconfigDirectory in HalconfigParserMocker #2172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @Autowired @Setter String halconfigDirectory; | ||
| private final String halconfigDirectory; | ||
|
|
||
| @Autowired |
There was a problem hiding this comment.
NIT: - allargs lombok instead of manual constroctor
jasonmcintosh
approved these changes
Jul 29, 2024
…Structure to pave the way for some refactoring to support java 17
as a general improvement and also to pave the way to cleanly specify a non-null halconfigDirectory during testing.
…cture as a general improvement and also to pave the way to cleanly specify a non-null halconfigDirectory during testing.
…arserMocker
since tests like this fail in java 17 otherwise:
> Task :halyard-config:test
AccountServiceSpec > load an existent account node FAILED
java.lang.NullPointerException
at java.base/java.util.Objects.requireNonNull(Objects.java:209)
at java.base/sun.nio.fs.UnixFileSystem.getPath(UnixFileSystem.java:263)
at java.base/java.nio.file.Path.of(Path.java:147)
at java.base/java.nio.file.Paths.get(Paths.java:69)
at com.netflix.spinnaker.halyard.config.config.v1.HalconfigDirectoryStructure.getHalconfigPath(HalconfigDirectoryStructure.java:50)
at com.netflix.spinnaker.halyard.config.config.v1.HalconfigParser.transformHalconfig(HalconfigParser.java:159)
at com.netflix.spinnaker.halyard.config.services.v1.HalconfigParserMocker.mockHalconfigParser(HalconfigParserMocker.groovy:38)
at com.netflix.spinnaker.halyard.config.services.v1.AccountServiceSpec.makeAccountService(AccountServiceSpec.groovy:34)
at com.netflix.spinnaker.halyard.config.services.v1.AccountServiceSpec.load an existent account node(AccountServiceSpec.groovy:56)
…ructure to reduce boilerplate
dbyron-sf
force-pushed
the
config-cleanup
branch
from
70f4163 to
17aad29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since tests like this fail in java 17 otherwise:
See e.g. https://github.com/spinnaker/halyard/actions/runs/10112106527/job/27965430799?pr=2171.