55 stat id map not populated in league resource #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er-stats Enhancement/include points in player stats
…er-stats Adjusting player stats to use league resource instead of player
…de-points-in-player-stats Fixes by autopep8 action
…om:DMcP89/yahoo_fantasy_api into enhancement/include-points-in-player-stats
…er-stats Clean up
The two main changes here are allowing a handler to be passed to the constructor of the League object and calling certain functions to populate its caches. If this is acceptable we can look to apply similar changes to the other classes.
|
@spilchen would like your input here before merging, any objections? |
spilchen
requested changes
Jan 25, 2025
|
@spilchen I have moved the function calls to populate the stats cache into the inject_yhandler function of the League class. This is the only way I can see to populate the cache at league creation as we need the yhandler in place for the call to settings(). The only alternative to this I can see is having the game code get passed into the league object, but that would require a lot more changes then this. Let me know what you think. |
spilchen
reviewed
Jan 29, 2025
DMcP89
force-pushed
the
55-stat-id-map-not-populated-in-league-resource
branch
from
8570e15 to
8962602
Compare
|
Should be good to go now @spilchen |
spilchen
reviewed
Jan 31, 2025
spilchen
approved these changes
Feb 2, 2025
Repository owner
deleted a comment
Feb 4, 2025
Repository owner
deleted a comment
Feb 4, 2025
Repository owner
deleted a comment
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to allow league objects to populate caches at instantiation
closes #55