-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update day parameter in team.change_positions() to time_frame #50
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! I had a couple of suggestions. Can you also bump the version of the api (in setup.py) to 2.9.0?
Can you add a unit test as well?
Seems to be an issue with the unit test framework, got the following output: python setup.py test
!!
!! |
I'm not sure why you encountered the error when running the tests. They passed fine on my end, but I run on Linux, not Windows, so the issue might be related to the operating system. |
Position change for NFL leagues requires week rather than date, see documentation below:
This pull request replaces the day parameter with a more generic time_frame in the change_positions method in the Team class.
This argument may be either a datetime.date or week number for use in NFL leagues.