Add support for expandEnv #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Faisal Memon <[email protected]>
azdagron
reviewed
Dec 20, 2023
|
Sorry this has been sitting for so long, @faisal-memon . I think it's good to go once we correct the casing on the flag. |
Signed-off-by: Faisal Memon <[email protected]>
MarcosDY
reviewed
Dec 21, 2023
Signed-off-by: Faisal Memon <[email protected]>
MarcosDY
approved these changes
Jan 10, 2024
faisal-memon
added a commit
to faisal-memon/spire-controller-manager
that referenced
this pull request
Jan 16, 2024
* Add support for expandEnv Signed-off-by: Faisal Memon <[email protected]>
azdagron
added a commit
that referenced
this pull request
Jan 16, 2024
* Bump linter to 1.52.2 Signed-off-by: Faisal Memon <[email protected]> * Update api/v1alpha1/clusterfederatedtrustdomain_webhook.go Co-authored-by: Marcos Yacob <[email protected]> Signed-off-by: Faisal Memon <[email protected]> * Add support for expandEnv (#256) * Add support for expandEnv Signed-off-by: Faisal Memon <[email protected]> * Bump actions/download-artifact from 4.1.0 to 4.1.1 (#279) Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 4.1.0 to 4.1.1. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v4.1.0...v4.1.1) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <[email protected]> * Bump github.com/onsi/ginkgo/v2 from 2.13.2 to 2.14.0 (#281) Bumps [github.com/onsi/ginkgo/v2](https://github.com/onsi/ginkgo) from 2.13.2 to 2.14.0. - [Release notes](https://github.com/onsi/ginkgo/releases) - [Changelog](https://github.com/onsi/ginkgo/blob/master/CHANGELOG.md) - [Commits](onsi/ginkgo@v2.13.2...v2.14.0) --- updated-dependencies: - dependency-name: github.com/onsi/ginkgo/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Faisal Memon <[email protected]> * Remove unnecessary _ Signed-off-by: Faisal Memon <[email protected]> * Remove more underscores Signed-off-by: Faisal Memon <[email protected]> --------- Signed-off-by: Faisal Memon <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Marcos Yacob <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Andrew Harding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly copied from SPIRE Repo
fixes #255