-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#261 Remove NodeResolver links from docs. #262
Open
idexter
wants to merge
2
commits into
spiffe:master
Choose a base branch
from
idexter:remove-resolver-plugin
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idexter
requested review from
sanderson042,
mchurichi,
ajessup,
Andres-GC,
evan2645 and
umairmkhan
as code owners
November 15, 2022 17:28
✅ Deploy Preview for spiffe ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Because it has been deprecated and removed in [v1.5.0](https://github.com/spiffe/spire/releases/tag/v1.5.0). Signed-off-by: Anton Kucherov <[email protected]>
idexter
force-pushed
the
remove-resolver-plugin
branch
from
November 15, 2022 17:33
2b5f867
to
9b60268
Compare
Signed-off-by: Anton Kucherov <[email protected]>
idexter
force-pushed
the
remove-resolver-plugin
branch
from
November 15, 2022 17:38
11f2d21
to
6ac32a6
Compare
idexter
commented
Nov 15, 2022
@@ -84,7 +82,7 @@ This bootstrap bundle is a default configuration, and should be replaced with cu | |||
{{< /warning >}} | |||
8. The server calls the AWS API to validate the proof. | |||
9. AWS acknowledges the document is valid. | |||
10. The server performs node resolution, to verify additional properties about the agent node and update its registration entries accordingly. For example, if the node was attested using Microsoft Azure Managed Service Identity (MSI). The resolver extracts the Tenant ID and Principal ID from the agent SPIFFE ID and uses the various Azure services to get information for building an additional set of selectors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about section 10
. How to change it properly or where to move it:
The server performs node resolution...
Fixes #263 |
This was referenced Mar 8, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it has been deprecated and removed in v1.5.0.