Fix DMX interval so it can vary

spensbot · Dec 11, 2023 · b63c37e · b63c37e
1 parent 96338f3
commit b63c37e
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/src/main/engine/connections/dmx/DmxConnectionUsb.ts b/src/main/engine/connections/dmx/DmxConnectionUsb.ts
@@ -38,9 +38,7 @@ export class DmxConnectionUsb {
     this.config = configByDeviceType[device.type as DmxUsbDeviceType]
     this.lastHz = this.config.refreshHz(this.c)
     this.device.name = this.config.name
-    this.intervalHandle = setInterval(() => {
-      this.sendDmx()
-    }, 1000 / this.config.refreshHz(c))
+    this.intervalHandle = this.beginInterval()
   }
 
   static async create(
@@ -56,14 +54,14 @@ export class DmxConnectionUsb {
     return new DmxConnectionUsb(device, serialConnection, c)
   }
 
-  beginInterval() {
-    this.intervalHandle = setInterval(() => {
+  beginInterval(): NodeJS.Timer {
+    return setInterval(() => {
       this.sendDmx()
       const hz = this.config.refreshHz(this.c)
       if (this.lastHz !== hz) {
         this.lastHz = hz
         clearInterval(this.intervalHandle)
-        this.beginInterval()
+        this.intervalHandle = this.beginInterval()
       }
     }, 1000 / this.config.refreshHz(this.c))
   }

diff --git a/src/renderer/overlays/Devices.tsx b/src/renderer/overlays/Devices.tsx
@@ -69,7 +69,7 @@ export default function Devices({}: Props) {
                 {
                   <DraggableNumber
                     value={deviceSetup.connectionSettings.openDmxRefreshRateHz}
-                    min={10}
+                    min={5}
                     max={40}
                     onChange={(newVal) =>
                       dispatch(setOpenDmxRefreshRateHz(newVal))