Skip to content

Commit

Permalink
Options: Set level_compaction_dynamic_level_bytes as false by default
Browse files Browse the repository at this point in the history
This flag is not working properly with Speedb. see #786 for more details
  • Loading branch information
Yuval-Ariel committed Dec 25, 2023
1 parent 5e356db commit e07c2de
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions HISTORY.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

### Miscellaneous
* Remove leftover references to ROCKSDB_LITE (#755).
* Options: Set level_compaction_dynamic_level_bytes as false by default. This flag is not working properly with Speedb. see https://github.com/speedb-io/speedb/issues/786 for more details.

## Hazlenut 2.7.0 (27/10/2023)
Based on RocksDB 8.1.1
Expand Down
2 changes: 1 addition & 1 deletion include/rocksdb/advanced_options.h
Original file line number Diff line number Diff line change
Expand Up @@ -680,7 +680,7 @@ struct AdvancedColumnFamilyOptions {
// https://github.com/facebook/rocksdb/wiki/Leveled-Compaction#migrating-from-level_compaction_dynamic_level_bytesfalse-to-level_compaction_dynamic_level_bytestrue
//
// Default: true
bool level_compaction_dynamic_level_bytes = true;
bool level_compaction_dynamic_level_bytes = false;

// Allows RocksDB to generate files that are not exactly the target_file_size
// only for the non-bottommost files. Which can reduce the write-amplification
Expand Down

0 comments on commit e07c2de

Please sign in to comment.