Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix front-end skipping "Incertae sedis" leaf nodes #11

Open
wants to merge 4 commits into
base: catalogue_of_life_3
Choose a base branch
from

Conversation

maxpatiiuk
Copy link
Member

See #10. This is not a fix, but a workaround that should work until you need to select a family that is "Incertae sedis"

See #10. This is not a fix, but a workaround that should work
until you need to select a family that is "Incertae sedis"
@maxpatiiuk
Copy link
Member Author

Also, filter out out-of-order ranks when building and refactoring the generation to use arrays inside of string concatenation (same as #5, but for CoL)

Merge pull request #9 from specify/col-more-ranks
Copy link

@melton-jason melton-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Max, I have a concerning issue with the Taxa Generator.

Let's say I wanted to upload the 'standard' taxonomic ranks: Kingdom, Phylum, Class, Order, Family, Genus, and Species.

I have stumbled upon taxa (there are about 20,000 across all the trees for UBC) that are entirely missing one of those ranks (the authorities typically use the super or sub of that rank). The effect this has on the data generated by the Taxa Generator is that it 'cuts out' the missing rank, but the next included rank in the taxon will be placed where the missing rank was supposed to go, effectively shifting all lower ranks higher in the ordering.

I have uploaded 41 records from the Entomology tree where this issue occurs to the Vault
Things become clear when we isolate just one case (I will use the first row in the file as an example).
Every column is correct until we reach the Family column. If you follow the link in the 'Family Source' you will notice that this supposed Family is in fact a Genus.
The same thing occurs when looking at the Genus columns: where the Genus information should be there is instead the Species information.

Looking at the Classification from the Species Source, we see the issue is because this taxon does not have a direct Family, instead it has superfamily and subfamily.

From a Slack Direct Message with @maxpatiiuk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants