Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Handling of SQLAlchemy Boolean Fields #6144

Open
wants to merge 7 commits into
base: production
Choose a base branch
from
Open

Fix Handling of SQLAlchemy Boolean Fields #6144

wants to merge 7 commits into from
+30 −17

Conversation

acwhite211
Copy link
Member

@acwhite211 acwhite211 commented Jan 22, 2025 •
edited
Loading

Fixes #6022

Fix the mapping and creation of SQLAlchemy boolean fields from the datamodel.py file by creating a CustomBIT class.

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone

Testing instructions

Original Steps

  • Go to queries
  • Make report from existing query
  • See it works
  • Edit the query
  • Try to make a report
  • See that no errors occur

@acwhite211 acwhite211 added this to the 7.10 milestone Jan 23, 2025
@acwhite211 acwhite211 self-assigned this Jan 23, 2025
@acwhite211 acwhite211 marked this pull request as ready for review January 23, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarolineDenis CarolineDenis CarolineDenis approved these changes

@sharadsw sharadsw sharadsw approved these changes

@melton-jason melton-jason Awaiting requested review from melton-jason

@emenslin emenslin Awaiting requested review from emenslin

@lexiclevenger lexiclevenger Awaiting requested review from lexiclevenger

At least 3 approving reviews are required to merge this pull request.

Assignees

@acwhite211 acwhite211

Labels
None yet
Projects
General Tester Board
Status: 📋Back Log
Milestone
7.10
Development

Successfully merging this pull request may close these issues.

Can't make report from query saved in production
3 participants
@acwhite211 @sharadsw @CarolineDenis