feat(/xref): expose htmlProse field from webref
#401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
reviewed
Feb 12, 2024
sidvishnoi
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
My only concern here is with the size of xref.json file, which is already 11MB in size. It gets loaded on https://respec.org/xref/filter and as well as reloaded in webserver on cache-refresh.
I think we can leave it as an afterthought, as xref backend needs some work anyway (re: Edge server and all). But @dontcallmedom, can you tell the updated size of generated xref.json file?
sidvishnoi
changed the title
htmlProse field from webref
|
Merging and releasing for now though. |
|
renegerating it locally, I get 11949774 bytes for xref.json, so not much of a difference yet, but the risk that it grows significantly as other specs adopt the convention is real |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://github.com/w3c/respec/issues/4522#issuecomment-1933574282 for context