Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor LARK changes #39

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Minor LARK changes #39

merged 3 commits into from
Oct 1, 2024

Conversation

amanda849
Copy link
Contributor

  • Wrap escaped curly braces in syntax so LARK recognizes them as terminals
  • suffix_id should also include dashes (use id_punct rule). See lang ref for details
  • "//" with no trailing whitespace or characters should also be considered a comment

tbennun
tbennun approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@tbennun tbennun merged commit 02ecdf3 into spcl:master Oct 1, 2024
1 check passed
@amanda849 amanda849 deleted the mlir_lark branch October 1, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@amanda849 @tbennun