Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Resolve Segmentation Fault when IB_DEV_NAME is specified #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Resolve Segmentation Fault when IB_DEV_NAME is specified #1

wants to merge 1 commit into from

Conversation

nariaki3551
Copy link

@nariaki3551 nariaki3551 commented Nov 29, 2024 •
edited
Loading

The following command caused a Segmentation fault because dev variable is not properly set in ucc_tl_spin_init_p2p_context function when UCC_TL_SPIN_IB_DEV_NAME is specified.

mpirun -N 1 --host snail02:1,snail03:1 \
-x UCC_TL_SPIN_IB_DEV_NAME=mlx5_2 \
--mca coll_ucc_enable 1 \
--mca coll_ucc_priority 100 \
./osu-micro-benchmarks-7.3/c/mpi/collective/blocking/osu_allgather -m 4096:8388608

This pull request fixes this small bug.

After this fix, the osu benchmark runs successfully without segmentation faults.

@nariaki3551 nariaki3551 changed the title Set the dev variable when UCC_TL_SPIN_IB_DEV_NAME is specified Fix: Resolve Segmentation Fault when IB_DEV_NAME is specified Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nariaki3551