Changed visibility getter to throw instead of returning an "empty" FileAttributes instance #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta` exception instead of returning an "empty" `FileAttributes` instance.
Added test for new functionality and modified existing test ('can work with meta date') to not invoke visibility method.
|
I've just noticed that there's essentially the same problem with the |
…ception in case the MIME type detector cannot determine the MIME type of the file, ie. it returns null. Added tests to ensure this functions properly. Updated 'can work with meta date' test because the `mimeType` method can now throw.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the
visibilitymethod in the adapter returns an instance ofFileAttributeswith itsvisibilityfield set tonullsince visibility isn't supported. The problem is that Flysystem v3'svisibilitymethod's signature only allows for astringto be returned, notnull. This causes aTypeError: League\Flysystem\Filesystem::visibility(): Return value must be of type string, null returned, when invoking thevisibilitymethod on aFilesysteminstance that uses this adapter.Although the changed code still aligns with the public API and documentation, this should be considered a breaking change. Previously, the visibility method ALWAYS returned a
FileAttributesinstance, but now it will ALWAYS throw an exception.EDIT: I've also noticed an essentially identical problem with the
mimeTypemethod. The MIME type detector will return null in case it cannot determine the MIME Type. However, this causes aTypeErrorwhen called from theFilesystem::mimeTypemethod, because it may only return astring.