Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved handling of zeros in radial functions #10

Merged
merged 4 commits into from
Feb 16, 2018

Conversation

trettberg
Copy link
Contributor

@trettberg trettberg commented Dec 1, 2017

Radial functions bn often exihibt zeros at kr==0.
Previously a terrible hack was used to handle these.

This PR introduces a function replace_zeros to do this in an explicit and more graceful way.
It is automatically invoked by spherical_pw, spherical_ps, via a decorator.

The monofrequent case works transparently,
closes #4

Also, the kr==0 case in radial.weights and radial.circ_weights was fixed.
However, this is not yet done for point and line sources, see #9.

@trettberg trettberg merged commit bb91667 into master Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regularization of monofrequent radial filters does not work.
1 participant