Import CellExecutionError from nbconvert from the right place

[HealthyPear]

newer versions of nbconvert now define CellExecutionError only from nbconvert.preprocessors

I guess also a test is missing which made this part of code never trigger the crash ( I get it because in my sphinx build something is triggering it)

[mgeier]

Thanks for this PR!

If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in jupyter/nbconvert@c62f6e4.

BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

[HealthyPear]

Thanks for this PR!

If we want to be very clear, we should change the dependency in setup.py to nbconvert>=5.3,!=5.4, because this was added in jupyter/nbconvert@c62f6e4.

will do

BTW, I still have to figure out the CI failure, but it has nothing to do with your changes.

I see that the error has to do with the absence of pkg_resources.
As far as I know that dependency to deal with resources is deprecated in recent python versions in favor of importlib_resources.

[HealthyPear]

The CI issues seem gone anyway

[mgeier]

The CI error has been fixed (or rather worked-around) in #773.

Can you please re-base?

[HealthyPear]

The CI error has been fixed (or rather worked-around) in #773.

Can you please re-base?

Done.

[mgeier]

Thanks!