Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework #39

Draft
wants to merge 39 commits into
base: main
Choose a base branch
from
Draft

Rework #39

wants to merge 39 commits into from

Conversation

peter-svensson
Copy link
Member

No description provided.

@peter-svensson peter-svensson force-pushed the rework branch 2 times, most recently from a1cf8db to 9f2d061 Compare February 9, 2024 15:22
argoyle
argoyle previously approved these changes Feb 9, 2024
Copy link
Member

@argoyle argoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loads of changes. Looks good to me. Just one small comment. 🏎️

setup_consumer.go Outdated Show resolved Hide resolved
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: Patch coverage is 98.64560% with 6 lines in your changes missing coverage. Please review.

Project coverage is 97.76%. Comparing base (675eaab) to head (fcf2795).

Files with missing lines Patch % Lines
metrics.go 93.02% 2 Missing and 1 partial ⚠️
setup_consumer.go 96.62% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #39      +/-   ##
==========================================
+ Coverage   91.86%   97.76%   +5.89%     
==========================================
  Files           9       15       +6     
  Lines         578      582       +4     
==========================================
+ Hits          531      569      +38     
+ Misses         32        9      -23     
+ Partials       15        4      -11     
Flag Coverage Δ
tests 97.76% <98.64%> (+5.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants