-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add option for ignoring missing mapped types #34
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
=======================================
Coverage 91.86% 91.86%
=======================================
Files 9 9
Lines 578 578
=======================================
Hits 531 531
Misses 32 32
Partials 15 15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The option would be to just silently (or log) drop them if missing) 😉 ? |
For me that would be fine. Logging with debug perhaps (if we had such a logger). Would spam quite a lot otherwise possibly. |
Don't really remember the reasoning for erroring out if no mapping was found to be honest. |
75af8a5
to
0833990
Compare
either we add a debug possibility or we could silently drop them I would say.. |
Let's drop for now. We can always change later. I'll fix tomorrow. |
0833990
to
7b9e48f
Compare
7b9e48f
to
29f746b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
This is needed if not all services should define all mappings. 😂