Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for ignoring missing mapped types #34

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

argoyle
Copy link
Member

@argoyle argoyle commented Dec 16, 2023

This is needed if not all services should define all mappings. 😂

@peter-svensson peter-svensson enabled auto-merge (squash) December 16, 2023 21:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0b84aa) 91.86% compared to head (29f746b) 91.86%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   91.86%   91.86%           
=======================================
  Files           9        9           
  Lines         578      578           
=======================================
  Hits          531      531           
  Misses         32       32           
  Partials       15       15           
Flag Coverage Δ
tests 91.86% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peter-svensson
Copy link
Member

The option would be to just silently (or log) drop them if missing) 😉 ?
Would that be a problem?

@argoyle
Copy link
Member Author

argoyle commented Dec 16, 2023

For me that would be fine. Logging with debug perhaps (if we had such a logger). Would spam quite a lot otherwise possibly.

@argoyle
Copy link
Member Author

argoyle commented Dec 16, 2023

Don't really remember the reasoning for erroring out if no mapping was found to be honest.

@argoyle argoyle force-pushed the ignore-missing-mapped-types branch 2 times, most recently from 75af8a5 to 0833990 Compare December 17, 2023 13:20
@peter-svensson
Copy link
Member

For me that would be fine. Logging with debug perhaps (if we had such a logger). Would spam quite a lot otherwise possibly.

either we add a debug possibility or we could silently drop them I would say..

@argoyle
Copy link
Member Author

argoyle commented Dec 17, 2023

Let's drop for now. We can always change later. I'll fix tomorrow.

@argoyle argoyle force-pushed the ignore-missing-mapped-types branch from 0833990 to 7b9e48f Compare December 18, 2023 06:28
@argoyle argoyle force-pushed the ignore-missing-mapped-types branch from 7b9e48f to 29f746b Compare December 18, 2023 06:28
Copy link
Member

@peter-svensson peter-svensson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@peter-svensson peter-svensson merged commit 9e2bfd9 into main Dec 18, 2023
9 checks passed
@peter-svensson peter-svensson deleted the ignore-missing-mapped-types branch December 18, 2023 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants