acts dependencies: new versions as of 2025/01/08 #48465
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New year, new versions of the ACTS dependencies. This time, we have a new version of detray, a new version of algebra plugins, as well as a new version of ACTS itself.
wdconinc
reviewed
Jan 8, 2025
| @@ -77,6 +78,7 @@ class Detray(CMakePackage): | |||
| depends_on("acts-algebra-plugins +vc", when="+vc") | |||
| depends_on("acts-algebra-plugins +eigen", when="+eigen") | |||
| depends_on("acts-algebra-plugins +smatrix", when="+smatrix") | |||
| depends_on("[email protected]:", when="@0.87:") | |||
There was a problem hiding this comment.
More an upstream comment, but where is this manifested in acts-project/detray@v0.86.0...v0.87.0?
wdconinc
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Verified checksums and hashes. Checked CMakeLists.txt. One comment that probably more points to the absence of an explicit version requirement upstream, rather than something that is incorrect in this PR. I will mark as automerge, so if you want just mark that comment as resolved and it will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New year, new versions of the ACTS dependencies. This time, we have a new version of detray, a new version of algebra plugins, as well as a new version of ACTS itself.
Tagging @paulgessinger.