Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

root: Patch range restriction and gcc lower bound #48449

Merged
merged 3 commits into from
Jan 8, 2025
Merged

root: Patch range restriction and gcc lower bound #48449

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86a35c5
root: Restrict patch range
paulgessinger Jan 7, 2025
3a1d9d1
root: Set minimum gcc version for cxxstd=20
paulgessinger Jan 7, 2025
9f6caec
root: fix gcc range when cxxstd 20
wdconinc Jan 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion var/spack/repos/builtin/packages/root/package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ class Root(CMakePackage):
patch(
"https://github.com/root-project/root/commit/2f00d6df258906c1f6fe848135a88b836db3077f.patch?full_index=1",
sha256="8da36032082e65ae246c03558a4c3fd67b157d1d0c6d20adac9de263279d1db6",
when="@6.28:6.28.12",
when="@6.28.6:6.28.12",
)
patch(
"https://github.com/root-project/root/commit/14838b35600b08278e69bc3d8d8669773bc11399.patch?full_index=1",
Expand Down Expand Up @@ -452,6 +452,8 @@ class Root(CMakePackage):
"cxxstd=20", when="@:6.28.02", msg="C++20 support requires root version at least 6.28.04"
)

conflicts("%gcc@10:", when="cxxstd=20")
wdconinc marked this conversation as resolved.
Show resolved Hide resolved

# See https://github.com/root-project/root/issues/11128
conflicts("%clang@16:", when="@:6.26.07", msg="clang 16+ support was added in root 6.26.08")

Expand Down
Loading