Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove fits extension assumption for hooks #217

Merged
merged 3 commits into from
Jan 30, 2025

Conversation

braingram
Copy link
Collaborator

@braingram braingram commented Jan 23, 2025

This PR updates hooks to inherit output_ext from the hooked class.

Closes #216

JWST regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/12938827091
Roman regtests: https://github.com/spacetelescope/RegressionTests/actions/runs/12968661316

Regtests all passed

Tasks

  • update or add relevant tests
  • update relevant docstrings and / or docs/ page
  • Does this PR change any API used downstream? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • run regression tests with this branch installed ("git+https://github.com/<fork>/stpipe@<branch>")
news fragment change types...
  • changes/<PR#>.feature.rst: new feature
  • changes/<PR#>.bugfix.rst: fixes an issue
  • changes/<PR#>.doc.rst: documentation change
  • changes/<PR#>.removal.rst: deprecation or removal of public API
  • changes/<PR#>.misc.rst: infrastructure or miscellaneous change

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.37%. Comparing base (c947ebd) to head (d776d14).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #217      +/-   ##
==========================================
+ Coverage   95.28%   95.37%   +0.09%     
==========================================
  Files          37       37              
  Lines        3178     3245      +67     
==========================================
+ Hits         3028     3095      +67     
  Misses        150      150              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram marked this pull request as ready for review January 25, 2025 23:22
@braingram braingram requested a review from a team as a code owner January 25, 2025 23:22
@braingram braingram requested a review from nden January 27, 2025 14:04
Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Roman example now works.

@braingram braingram merged commit 3f0d344 into spacetelescope:main Jan 30, 2025
18 checks passed
@braingram braingram deleted the no_fits_hooks branch January 30, 2025 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

system call hooks assume a fits file extension.
2 participants