Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump: Update d3-format package #537

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bump: Update d3-format package #537

wants to merge 1 commit into from
+19 −12

Conversation

JhontSouth
Copy link

#minor

Description

This PR updates the d3-format package to the latest version and applies the necessary configuration to keep working in adaptive-expressions.

Specific Changes

  • Updated d3-format to version ^3.1.0.
  • Added prebuild scripts to adaptive-expressions to use tsup to compile ESM-only package.
  • Updated imports of d3-format in every class.

Testing

The following images show the adaptive-expressions unit tests working after the updates.
image

@coveralls
Copy link

coveralls commented Jan 8, 2025 •
edited
Loading

Pull Request Test Coverage Report for Build 12675101788

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 84.618%
Totals Coverage Status
Change from base Build 12635161688: 0.3%
Covered Lines: 20517
Relevant Lines: 23098
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sw-joelmut sw-joelmut sw-joelmut approved these changes

@ceciliaavila ceciliaavila ceciliaavila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JhontSouth @coveralls @ceciliaavila @sw-joelmut