clients/v1: add Roles service with RegisterRoleResources RPC #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unknwon
reviewed
Nov 6, 2024
Co-authored-by: Joe Chen <[email protected]>
bobheadxi
reviewed
Nov 6, 2024
bobheadxi
reviewed
Nov 6, 2024
|
|
||
| service RolesService { | ||
| rpc RegisterRoleResources (stream RegisterRoleResourcesRequest) returns (RegisterRoleResourcesResponse) { | ||
| option (sams_required_scopes) = "sams::roles.resources::write"; |
There was a problem hiding this comment.
technically we should require write and delete right, as this RPC can do both?
bobheadxi
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the RPC to register resources with SAMS to the clients API. These resources must have a valid
ResourceTypedefined in therolespackage. These resources will be used by SAMS to generate assets for Entitle grants.Registering resources requires a client to have the
sams::roles.resources::writescopeCloses CORE-397
Test plan
CI