improve observables usage #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sqs
commented
Sep 20, 2024
sqs
commented
- use custom isEqualJSON instead of JSON.stringify (for which key order matters)
- use switchMap instead of mergeMap to stop unwanted emissions
sqs
added a commit
to sourcegraph/cody
that referenced
this pull request
Sep 20, 2024
sqs
added a commit
to sourcegraph/cody
that referenced
this pull request
Sep 20, 2024
sqs
added a commit
to sourcegraph/cody
that referenced
this pull request
Sep 20, 2024
Incorporates sourcegraph/openctx#207 and sourcegraph/openctx#206. Fixes https://linear.app/sourcegraph/issue/CODY-3799/quieter-openctx-provider-ui-notifs-in-vs-code-and-better-error-logging. ## Test plan Open VS Code with an OpenCtx provider that throws an error. Ensure that no VS Code error notification is shown in the UI, and that it's logged to the `OpenCtx` output channel with the provider URI mentioned.
bevzzz
pushed a commit
to bevzzz/openctx
that referenced
this pull request
Dec 12, 2024
- use custom isEqualJSON instead of JSON.stringify (for which key order matters) - use switchMap instead of mergeMap to stop unwanted emissions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.