6.0.0 MVU upgrade docs update #946
Open
+222
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They should be "copy-pasteable" now. I put it in quotes because they have to paste it very specifically, but I think they are sufficiently idiot proof
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This is a separate thing, but autoupgrade doesn't really work very well with k8s deployments To fix this you'd need to go in and scale down the services that are continually trying to reach the DB |
|
Calling it for now but I suspect we'll have to special case Helm and add a note to the kubernetes upgrade notes saying that MVU for helm specifically can't got over the v5.10 boundary. I want to investigate packaging an override file that updates the images in the repo though |
MaedahBatool
requested changes
Feb 3, 2025
|
|
||
| The following doc contains detailed instructions for upgrading the built-in PostgreSQL databases. Via our `postgresql-16` and `postgresql-16-codeinsights` image entrypoint script. This doc assumes an admin is attempting to upgrade to Sourcegraph `6.0.0` from an older version (usually pre `5.10.0`) using one of our "deploy" repos. For more general info see [Upgrading PostgreSQL](/admin/postgres#upgrading-postgresql). | ||
|
|
||
| > WARNING: Upgrading the PostgreSQL database requires stopping your Sourcegraph deployment which will result in **downtime**. |
Co-authored-by: Maedah Batool <[email protected]>
Co-authored-by: Maedah Batool <[email protected]>
Chickensoupwithrice
approved these changes
Feb 3, 2025
DaedalusG
requested review from
MaedahBatool,
jdpleiness,
loujar and
marcleblanc2
| ```yaml | ||
| migrator: | ||
| container_name: migrator | ||
| image: 'index.docker.io/sourcegraph/migrator:5.0.4' | ||
| image: 'index.docker.io/sourcegraph/migrator:6.0.0' |
There was a problem hiding this comment.
we may want to use CURRENT_VERSION_STRING stuff here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the upgrade docs embellishing instructions for the different deployment methods to include better coverage and handling of the Postgres 16 database upgrade when crossing over Sourcegraph 5.10.0 using migrator 6.0.0 or greater.
The notable change here is the inclusion of deployment specific builtin Postgres upgrade instructions, as well as changes to the MVU upgrade docs suggesting that users bring down all services and merge upstream changes from their target version into their release branch before performing their migrator upgrade. Due to migrators
depends_onclause this will ensure that Postgres upgrades occur before migrator attempts connection to a PG12 database. This gets around the connect bouncer added in 6.0.0 which blocks services connection to our dbsTesting