-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revamp config docs with helm-docs #50
Conversation
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
52ce59b
to
f027f17
Compare
754e93c
to
54a8e10
Compare
f027f17
to
80d32c7
Compare
54a8e10
to
01d51e1
Compare
272c470
to
c61fee9
Compare
c61fee9
to
3929944
Compare
3929944
to
bdddee6
Compare
26210d7
to
1366f4b
Compare
1366f4b
to
09f629a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Thanks for slogging through all this.
Side note - when you squash commits during an open review, it makes it hard for reviewers to tell what has changed since the PR was first opened. It's a faster and more reliable review cycle if fixes are kept as separate commits until the PR is merged.
Good call out! I can imagine it's pretty hard to inspect the diff again for large PR like this. |
Graphite Merge Job Current status: ✅ Merged This pull request was successfully merged as part of a stack. This comment was auto-generated by Graphite. Job Reference: yNqXdfNl9dvIL5h0XluD |
This PR added autogen docs based on
values.yaml
.charts/<chart_name>/README.md
should no longer be edited, and changes should be made incharts/<chart_name>/README.md.gotmpl
View the rendered version here
Test plan
Run
./scripts/helm-docs.sh
, you should be able to generate the README.mdclose https://github.com/sourcegraph/sourcegraph/issues/31016