Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix @openctx/vscode-lib initialization for Cody Web #4796

Merged
merged 1 commit into from
Jul 5, 2024
Merged

Fix @openctx/vscode-lib initialization for Cody Web #4796

merged 1 commit into from
Jul 5, 2024

Conversation

vovakulikov
Copy link
Contributor

@openctx/vscode-lib uses global. sets under the hood which breaks Cody Web use case since we're importing vscode-lib within web worker context where we don't have global object.

This PR adds hack/workaround for Cody Web, proper fix should happen in @openctx/vscode-lib here sourcegraph/openctx#169

Test plan

  • Run cody web demo
  • Check that you can see and use repositories and files mentions providers

@vovakulikov vovakulikov requested a review from a team July 5, 2024 17:14
@vovakulikov vovakulikov self-assigned this Jul 5, 2024
abeatrix
abeatrix approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was able to start the demo web app:
image

@vovakulikov vovakulikov merged commit 8703316 into main Jul 5, 2024
19 checks passed
@vovakulikov vovakulikov deleted the vk/fix-openctx-vscode-lib-problem branch July 5, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abeatrix abeatrix abeatrix approved these changes

Assignees

@vovakulikov vovakulikov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vovakulikov @abeatrix