feat: update contract #7

Tranduy1dol · 2024-08-12T10:46:36Z

Check List

linear · 2024-08-12T10:46:38Z

MZK-42 Settlement Contract in Aptos

Convert Contract
Write Unit Test

Reference:

Starknet.sol - WORKSPACE - Blockscan contract source code viewer
consensus-specs/specs/deneb/polynomial-commitments.md at dev · ethereum/consensus-specs (github.com)
go-ethereum/crypto/kzg4844/trusted_setup.json at master · ethereum/go-ethereum (github.com)
ethereum/py_ecc: Python implementation of ECC pairing and bn_128 and bls12_381 curve operations (github.com)

Move.toml

sources/libs/bytes.move

sources/libs/named_storage.move

sources/starknet_sovereign.move

zk-steve · 2024-08-22T03:14:31Z

sources/components/fact_registry.move

remove has_registered_fact()
make init_fact_registry() as entry func
remove check if (exists(@starknet_addr) == false) {
init_fact_registry(signer);
};

remove if (verifier_fact.any_fact_registered == false) {
verifier_fact.any_fact_registered = true;
}

zk-steve · 2024-08-22T03:15:28Z

sources/components/fact_registry.move

Why register_fact() doesn't have any validation?

sources/components/onchain_data_fact_tree_encoded.move

zk-steve · 2024-08-22T03:39:05Z

sources/components/onchain_data_fact_tree_encoded.move

-        let main_public_input_length: u256 = (vector::length(&program_output) as u256);
-        let main_public_input_hash: vector<u8> = keccak256(bytes::vec_to_bytes_be(&program_output));
+        let main_public_input_length: u256 = (vector::length(program_output) as u256);
+        let main_public_input_hash: vector<u8> = keccak256(bytes::vec_to_bytes_be(program_output));
        let buffer = vector::empty<u8>();


use main_public_input_hash as buffer directly

zk-steve · 2024-08-22T03:51:17Z

sources/starknet_sovereign.move

find all vector::empty() in all files and replace them with the first append

zk-steve · 2024-08-22T04:33:59Z

sources/kzg/kzg_helper.move

@@ -19,12 +14,11 @@ module starknet_addr::kzg_helper {
            vector::length(commitment) == 48,
            EINVALID_KZG_COMMITMENT
        );
-        let versioned_hash_version_kzg = VERSIONED_HASH_VERSION_KZG;
        let hash_commitment = hash::sha2_256(*commitment);
        let hash_commitment_silce = vector::slice(&hash_commitment, 1, vector::length(&hash_commitment));


replace index 0 = VERSIONED_HASH_VERSION_KZG directly

zk-steve · 2024-08-22T04:42:15Z

sources/kzg/pre_compile.move

+        let versioned_hash = vector::slice(&bytes, 0, 32);
+        let z = vector::slice(&bytes, 32, 64);
+        let y = vector::slice(&bytes, 64, 96);
+        let commitment = vector::slice(&bytes, 96, 144);
+        let proof = vector::slice(&bytes, 144, 192);


let proof = vector::trim(&mut bytes, 144); let commitment = vector::trim(&mut bytes, 96); let y = vector::trim_reverse(&mut bytes, 64); let z = vector::trim_reverse(&mut bytes, 32); let versioned_hash = bytes;

zk-steve · 2024-08-22T04:50:43Z

sources/starknet_storage.move

remove this file

zk-steve · 2024-08-22T06:49:35Z

sources/kzg/kzg_helper.move

-        let result = vector::empty<u8>();
-        vector::append(&mut result, versioned_hash_version_kzg);
-        vector::append(&mut result, hash_commitment_silce);
+        let fisrt_byte = vector::borrow_mut(&mut hash_commitment, 0);


vector::borrow_mut(&mut hash_commitment, 0) = VERSIONED_HASH_VERSION_KZG

zk-steve · 2024-08-22T06:53:12Z

sources/starknet_validity.move

+                global_root,
+                block_number,
+                block_hash
+            ));
    }

    #[view]


move all view functions down below the entry functions

zk-steve · 2024-08-22T06:55:25Z

sources/starknet_validity.move

public fun get_blob_hash(commitment: &vector<u8>): vector<u8> {

=> public inline fun get_blob_hash(commitment: &vector): vector {

zk-steve · 2024-08-22T07:08:20Z

sources/starknet_validity.move

@@ -140,7 +136,6 @@ module starknet_addr::starknet_validity {
        onchain_data_hash: u256,


public fun state_block_number(): -> public inline fun state_block_number():

zk-steve · 2024-08-22T07:13:23Z

sources/starknet_validity.move

        assert!(
            state_block_number() == initial_block_number + 1,
            EINVALID_FINAL_BLOCK_NUMBER
        );
    }

-    public fun update_state_internal(
+    public fun update_internal_state(


Suggested change

public fun update_internal_state(

public(friend) fun update_internal_state(

zk-steve · 2024-08-22T07:26:29Z

sources/starknet_storage.move

public fun initialize(s: &signer, program_hash: u256, verifier: address, config_hash: u256, state: State)
should only allow to init if the resource hasn't been created

zk-steve · 2024-08-22T07:27:11Z

sources/starknet_storage.move

all set* func should be public(friend)

do it with all other files

zk-steve · 2024-08-22T08:31:35Z

sources/starknet_validity.move

@@ -230,7 +222,7 @@ module starknet_addr::starknet_validity {
        verify_kzg_proof(&kzg_segment, &kzg_proof);

        let state_transition_fact = keccak256(vec_to_bytes_be(&program_output));
-        update_state_internal(&program_output, state_transition_fact);
+        update_internal_state(&program_output, state_transition_fact);

        // Re-entrancy protection: validate final block number


no Reentrancy in Move, remove this check, and the first line

zk-steve · 2024-08-22T08:32:47Z

sources/starknet_validity.move

@@ -230,7 +222,7 @@ module starknet_addr::starknet_validity {
        verify_kzg_proof(&kzg_segment, &kzg_proof);


let kzg_segment = vector::slice(&pre_kzg_segment, 0u64, KZG_SEGMENT_SIZE);

=> let kzg_segment = vector::slice(&pre_kzg_segment, 0, KZG_SEGMENT_SIZE);

let pre_kzg_segment = vector::slice(
&program_output,
HEADER_SIZE,
vector::length(&program_output)
);
use trim

zk-steve · 2024-08-22T16:20:10Z

sources/starknet_storage.move

-            state,
-            sidecar
-        });
+        if (!is_initialized(verifier)) {


assert(!is_initialized(verifier), ERR)

zk-steve · 2024-08-22T16:21:09Z

sources/starknet_storage.move

        storage.program_hash = new_program_hash;
    }

    public fun get_program_hash(addr: address): u256 acquires Storage {
        borrow_global_mut<Storage>(addr).program_hash
    }

-    public fun set_config_hash(storage: &mut Storage, new_config_hash: u256) {
+    public(friend) fun set_config_hash(storage: &mut Storage, new_config_hash: u256) {
        storage.config_hash = new_config_hash;
    }

    public fun get_config_hash(addr: address): u256 acquires Storage {
        borrow_global_mut<Storage>(addr).config_hash


Suggested change

borrow_global_mut<Storage>(addr).config_hash

borrow_global<Storage>(addr).config_hash

apply for all similar errors above

zk-steve · 2024-08-22T16:33:38Z

sources/starknet_validity.move


-        let (precompile_output, ok) = pre_compile::point_evaluation_precompile(precompile_input);
-        assert!(ok, EPOINT_EVALUATION_PRECOMPILE_CALL_FAILED);
+        let precompile_output = pre_compile::point_evaluation_precompile(blob_hash);

        assert!(
            keccak256(precompile_output) == POINT_EVALUATION_PRECOMPILE_OUTPUT,
            EUNEXPECTED_POINT_EVALUATION_PRECOMPILE_OUTPUT
        );


Add TODO: check blob registration

Tranduy1dol requested a review from zk-steve August 12, 2024 10:46

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch from 421744b to bdbc6c2 Compare August 15, 2024 08:59

zk-steve reviewed Aug 21, 2024

View reviewed changes

Move.toml Show resolved Hide resolved

zk-steve reviewed Aug 21, 2024

View reviewed changes

sources/libs/bytes.move Outdated Show resolved Hide resolved

zk-steve reviewed Aug 21, 2024

View reviewed changes

sources/libs/bytes.move Outdated Show resolved Hide resolved

zk-steve reviewed Aug 21, 2024

View reviewed changes

sources/libs/named_storage.move Outdated Show resolved Hide resolved

zk-steve reviewed Aug 21, 2024

View reviewed changes

sources/starknet_sovereign.move Outdated Show resolved Hide resolved

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch 8 times, most recently from b6913ed to afb5844 Compare August 22, 2024 03:09

zk-steve reviewed Aug 22, 2024

View reviewed changes

sources/components/fact_registry.move Outdated

Copy link

Contributor

zk-steve Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why register_fact() doesn't have any validation?

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch from afb5844 to e7dbb49 Compare August 22, 2024 03:30

zk-steve reviewed Aug 22, 2024

View reviewed changes

sources/components/onchain_data_fact_tree_encoded.move Outdated Show resolved Hide resolved

zk-steve reviewed Aug 22, 2024

View reviewed changes

sources/starknet_sovereign.move

Copy link

Contributor

zk-steve Aug 22, 2024 •

edited

Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

find all vector::empty() in all files and replace them with the first append

zk-steve force-pushed the main branch 2 times, most recently from ff8a792 to 156884f Compare August 22, 2024 04:28

zk-steve reviewed Aug 22, 2024

View reviewed changes

sources/starknet_storage.move

Copy link

Contributor

zk-steve Aug 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this file

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch 3 times, most recently from 3964fd3 to e4220be Compare August 22, 2024 06:45

zk-steve reviewed Aug 22, 2024

View reviewed changes

zk-steve force-pushed the main branch from 156884f to fe4cd5a Compare August 22, 2024 07:19

zk-steve reviewed Aug 22, 2024

View reviewed changes

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch from e4220be to bd7fbaf Compare August 22, 2024 09:46

zk-steve reviewed Aug 22, 2024

View reviewed changes

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch 2 times, most recently from 1eebaff to 5dcc3e1 Compare August 29, 2024 08:56

refactor code

d5ce90d

Tranduy1dol force-pushed the mzk-42-settlement-contract-in-aptos branch from 5dcc3e1 to d477ed9 Compare September 12, 2024 02:44

feat: add github action

3e6e119

Draply force-pushed the mzk-42-settlement-contract-in-aptos branch from d477ed9 to 3e6e119 Compare September 12, 2024 03:00

fix(test): fix error when use event_handle

b4b9244

Draply force-pushed the mzk-42-settlement-contract-in-aptos branch from 198119d to b4b9244 Compare September 12, 2024 03:22

add navori libs

a7661d7

Tranduy1dol merged commit d77f32b into main Dec 13, 2024
1 check failed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: update contract #7

feat: update contract #7

Tranduy1dol commented Aug 12, 2024 •

edited

Loading

linear bot commented Aug 12, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

zk-steve Aug 22, 2024

		@@ -140,7 +136,6 @@ module starknet_addr::starknet_validity {
		onchain_data_hash: u256,

	public fun update_internal_state(
	public(friend) fun update_internal_state(

		@@ -230,7 +222,7 @@ module starknet_addr::starknet_validity {
		verify_kzg_proof(&kzg_segment, &kzg_proof);

	borrow_global_mut<Storage>(addr).config_hash
	borrow_global<Storage>(addr).config_hash

feat: update contract #7

feat: update contract #7

Conversation

Tranduy1dol commented Aug 12, 2024 • edited Loading

Check List

linear bot commented Aug 12, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zk-steve Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zk-steve Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zk-steve Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zk-steve Aug 22, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Tranduy1dol commented Aug 12, 2024 •

edited

Loading

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024 •

edited

Loading

zk-steve Aug 22, 2024 •

edited

Loading