Merge pull request #188 from sot/images-default

Change the get_aca_images default to bgsub=False
sot · Jan 10, 2025 · 7bcfac4 · 7bcfac4
2 parents c29f3fe + 5181dde
commit 7bcfac4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/chandra_aca/aca_image.py b/chandra_aca/aca_image.py
@@ -847,7 +847,7 @@ def get_psf_image(
 
 @retry.retry(exceptions=requests.exceptions.RequestException, delay=5, tries=3)
 def get_aca_images(
-    start: CxoTimeLike, stop: CxoTimeLike, bgsub=True, source="maude", **maude_kwargs
+    start: CxoTimeLike, stop: CxoTimeLike, bgsub=False, source="maude", **maude_kwargs
 ) -> Table:
     """
     Get ACA images and ancillary data from either the MAUDE or CXC data sources.
@@ -880,7 +880,7 @@ def get_aca_images(
     stop : CxoTimeLike
         Stop time (CXC sec).
     bgsub : bool
-        Include background subtracted images in output table.
+        Include background subtracted images in output table. Default is False.
     source : str
         Data source for image and temperature telemetry ('maude' or 'cxc'). For 'cxc',
         the image telemetry is from mica and temperature telemetry is from CXC L0 via

diff --git a/chandra_aca/tests/test_dark_subtract.py b/chandra_aca/tests/test_dark_subtract.py
@@ -284,7 +284,7 @@ def test_dcsub_aca_images_maude():
         imgs_table, img_dark=img_dark, tccd_dark=tccd_dark, t_ccd_vals=t_ccds
     )
 
-    imgs_bgsub_table = get_aca_images(tstart, tstop, source="maude")
+    imgs_bgsub_table = get_aca_images(tstart, tstop, source="maude", bgsub=True)
 
     exp0 = np.array(
         [