-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] 동적 Index html #261
[Fix] 동적 Index html #261
Conversation
|
Deploying sopt-recruiting-frontend with Cloudflare Pages
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
고생하셨습니두~~~
아 그리고 저희 branch name 은 camelCase가 아니고 kebab-case 이지 않았나유?
<meta property="og:locale" content="ko_KR" /> | ||
<!-- <meta property="og:url" content="https://www.someurl.com" /> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이제는 url도 추가해줄 수 있어요~
<meta property="twitter:card" content="website" /> | ||
<meta name="twitter:title" content="SOPT 35기 모집 지원하기" /> | ||
<meta name="twitter:description" content="SOPT의 신입 기수 모집페이지입니다." /> | ||
<!-- <meta property="twitter:site" content="https://www.someurl.com" /> --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도요
@eonseok-jeon url 태그 추가했습니다! 브랜치 전략은 네네 kebab 맞는데 제가 앱잼하고 와서 혼동했네요 ㅠㅠ |
Related Issue : Closes #223
🧑🎤 Summary
react-helmet-async
라이브러리 사용해서 메이커스 여부에 따라 동적으로 head 태그 구현해줬습니다🧑🎤 Screenshot
🧑🎤 Comment
season
과isMakers
데이터 가져다가 사용하는데, 불러오는 시간 때문에 페이지 로딩시간 동안 title에undefined 기 모집
이렇게 undefined가 섞여나오더라고요? 그게 너무 보기 싫어서 아직 안불러와졌을 때 (데이터 undefined일때) 보여줄 디폴트 텍스트 따로 설정하였습니다