Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

번쩍 수정 API 연결 #1006

Merged
merged 11 commits into from
Feb 4, 2025
Merged

번쩍 수정 API 연결 #1006

merged 11 commits into from
Feb 4, 2025

Conversation

j-nary
Copy link
Member

@j-nary j-nary commented Feb 3, 2025

🚩 관련 이슈

📋 작업 내용

  • 번쩍 수정 API 연결

@j-nary j-nary self-assigned this Feb 3, 2025
Copy link

height bot commented Feb 3, 2025

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Contributor

@borimong borimong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 수고하셨습니다! 이전 UI 커밋이 많이 껴있는데 원한다면 rebase 해봐도 좋을 것 같아요! (그러나 rebase 는 까딱하면 커밋이 아예 날아가버리기 때문에.. 호불호가 갈리긴 합니다!!)
추가로 혹시 번쩍 "장소"가 "협의 후 결정"인 경우에, 번쩍 상세 페이지에서 "장소" 가 아예 보이지 않는 것이 의도된 기획이 맞을까요??

@j-nary
Copy link
Member Author

j-nary commented Feb 4, 2025

LGTM! 수고하셨습니다! 이전 UI 커밋이 많이 껴있는데 원한다면 rebase 해봐도 좋을 것 같아요! (그러나 rebase 는 까딱하면 커밋이 아예 날아가버리기 때문에.. 호불호가 갈리긴 합니다!!) 추가로 혹시 번쩍 "장소"가 "협의 후 결정"인 경우에, 번쩍 상세 페이지에서 "장소" 가 아예 보이지 않는 것이 의도된 기획이 맞을까요??

이 부분 기디에 전달 드리겠습니다 ~!

@j-nary j-nary merged commit 1121615 into develop Feb 4, 2025
1 check passed
@j-nary j-nary deleted the feat/#1005 branch February 4, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

번쩍 수정 API 연결
2 participants