-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1011] Google Sign In 설정 #1014
Open
l2hyunwoo
wants to merge
12
commits into
feature/#1011-login-mock-server
Choose a base branch
from
feature/#1011-google-sign-in
base: feature/#1011-login-mock-server
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+133
−55
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a18aaa4
[#1011] Add google-auth
l2hyunwoo b07c874
[#1011] PlaygroundAuth deprecate 처리
l2hyunwoo 082ae5e
[#1011] Add suspendRunCatching
l2hyunwoo 4341bba
[#1011] Add Google auth laucnher
l2hyunwoo 2f8f12c
[#1011] GoogleSignIn 설정
l2hyunwoo a9ff05d
[#1011] 코드리뷰 반영 (Legacy api 삭제)
l2hyunwoo bd57b6b
[#1011] CredentialManager, google id 의존성 추가, legacy google auth 삭제
l2hyunwoo 09fe535
[#1011] Remove deprecated signature
l2hyunwoo 57291ad
[#1011] SERVER_CLIENT_ID 추가
l2hyunwoo 995e4d8
[#1011] Credential Manager 적용 (코드리뷰 적용)
l2hyunwoo 31eb67b
[#1011] Remove todo
l2hyunwoo 74b0cf9
[#1011] Add androidx.credential
l2hyunwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
core/common/src/main/java/org/sopt/official/common/coroutines/runCatching.kt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
package org.sopt.official.common.coroutines | ||
|
||
import kotlinx.coroutines.TimeoutCancellationException | ||
import kotlin.coroutines.cancellation.CancellationException | ||
|
||
suspend inline fun <R> suspendRunCatching(block: () -> R): Result<R> { | ||
return try { | ||
Result.success(block()) | ||
} catch (t: TimeoutCancellationException) { | ||
Result.failure(t) | ||
} catch (c: CancellationException) { | ||
throw c | ||
} catch (e: Throwable) { | ||
Result.failure(e) | ||
} | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오호 이 함수를 추가한 이유는 더 상세한 에러를 잡기 위함인가요...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
정확히는 저 CancellationException은 이 코루틴에서 에러가 발생했을 때 다른 코루틴으로의 예외전파를 시키는 것을 막지 않게 하기 위해서 추가한 코드에요
Reference - Kotlin/kotlinx.coroutines#1814