Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ui): SelectV2 TriggerContent 내 커스텀 Icon을 적용할 수 있도록 icon prop 추가. #228

Merged
merged 2 commits into from
Dec 15, 2024

Conversation

Brokyeom
Copy link
Member

변경사항

  • SelectV2.TriggerContent의 아이콘이 ChevronDown만으로 고정되어 있던 형태에서, ReactNode type의 icon 을 추가하여 다양한 아이콘을 추가할 수 있도록 수정합니다.

링크

시급한 정도

🏃‍♂️ 보통 : 최대한 빠르게 리뷰 부탁드립니다.

기타 사항

Copy link

height bot commented Dec 14, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link

changeset-bot bot commented Dec 14, 2024

🦋 Changeset detected

Latest commit: 82505d3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sopt-makers/ui Patch
docs Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 14, 2024
Copy link
Member

@jungwoo3490 jungwoo3490 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Brokyeom Brokyeom merged commit 161f23a into main Dec 15, 2024
1 check passed
@Brokyeom Brokyeom deleted the refactor/ui-select-content branch December 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants