Change the test case name to not include 'teamd_' in it #16456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16456 in repo sonic-net/sonic-mgmt |
wangxin
approved these changes
Jan 14, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Commenter does not have sufficient privileges for PR 16456 in repo sonic-net/sonic-mgmt |
|
/azpw run |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
If the test case name has the 'teamd_' in it, in the loganalyzer, when add the marker, the log will be writen to the /var/log/teamd.log, but not the /var/log/syslog, it will fail the loganalyzer
nhe-NV
force-pushed
the
update_test_name
branch
from
928cf95 to
c3bedf8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the test case name has the 'teamd_' in it, in the loganalyzer, when add the marker, the log will be writen to the /var/log/teamd.log, but not the /var/log/syslog, it will fail the loganalyzer
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Change the test cases name to not fail the loganalyzer
When run the test case: tests/pc/test_retry_count.py:: TestNeighborRetryCount:: test_kill_teamd_lag_up, it failed when add_end_marker in the loganalyzer, and could reproduce it by manual.
sudo python /tmp/loganalyzer.py --action add_end_marker --run_id test_kill_teamd_lag_up.2025-01-05-03:24:03
Traceback (most recent call last):
File "/tmp/loganalyzer.py", line 878, in
main(sys.argv[1:])
File "/tmp/loganalyzer.py", line 859, in main
analyzer.place_marker(
File "/tmp/loganalyzer.py", line 262, in place_marker
raise RuntimeError(
RuntimeError: cannot find marker end-LogAnalyzer-test_kill_teamd_lag_up.2025-01-05-03:24:03 in /var/log/syslog
The root cause of the failure is due to the “teamd_” in the log msg. then the log will be direct to the “ /var/log/teamd.log”, so we could not find it in the /var/log/syslog.
In the file, /etc/rsyslog.d/00-sonic.conf, we could found the redirect logic of the log
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation