[infra] Enforce core_dump_and_config_check run order
#16453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wangxin
previously approved these changes
Jan 10, 2025
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
force-pushed
the
infra_reorder_cdncc
branch
from
164fb68 to
0efece8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Let's enforce `core_dump_and_config_check` run order: 1. runs before any other module level fixtures in setup. 2. runs after any other module level fixtures in teardown. Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
force-pushed
the
infra_reorder_cdncc
branch
from
0efece8 to
7f53832
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Test run suffers from unneccesary config reloads from
core_dump_and_config_check;the root cause is
core_dump_and_config_checkruns before those fixtures from testcase that restore the configuration in teardown, so the configuration check is always failing.How did you do it?
Let's enforce
core_dump_and_config_checkrun order:How did you verify/test it?
Runs
dualtor_io/test_tor_bgp_failure.py,core_dump_and_config_checkruns before temp_enable_bgp_autorestart in setup and runs after temp_enable_bgp_autorestart in teardown;temp_enable_bgp_autorestart could recover the feature autorestart config before
core_dump_and_config_check, and the config check will pass (no more config reload).Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation