-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test_pfcwd_wb] increase delay time for detecting pfcwd storm #16445
Merged
StormLiangMS
merged 1 commit into
sonic-net:master
from
lipxu:20250110_publicMaster_pfcwd_WR
Jan 13, 2025
Merged
[test_pfcwd_wb] increase delay time for detecting pfcwd storm #16445
StormLiangMS
merged 1 commit into
sonic-net:master
from
lipxu:20250110_publicMaster_pfcwd_WR
Jan 13, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lipxu
changed the title
[] increase delay time for detecting pfcwd storm
[test_pfcwd_wb] increase delay time for detecting pfcwd storm
Jan 10, 2025
StormLiangMS
approved these changes
Jan 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@lipxu PR conflicts with 202405 branch |
@lipxu PR conflicts with 202411 branch |
lipxu
added a commit
to lipxu/sonic-mgmt-lipxu-fork
that referenced
this pull request
Jan 13, 2025
…-net#16445) What is the motivation for this PR? Script log Analyzer timestamp is 2025-01-07 13:26:55.978427 while the real detect timestamp in syslog is Jan 7 13:27:18.132683. Need delay more time to grep the syslog 2025 Jan 7 13:26:55.996909 bjw2-can-7260-2 DEBUG extract_log combine_logs from file /var/log/syslog create time 2025-01-07 13:26:55.978427, size 4236007 syslog:23447:2025 Jan 7 13:27:18.132683 bjw2-can-7260-2 NOTICE swss#orchagent: :- report_pfc_storm: PFC Watchdog detected PFC storm on port Ethernet24, queue index 3, queue id 0x1500000000014d and port id 0x1000000000001 How did you do it? Increase the delay time and add some debug log in script How did you verify/test it? Use elastic to run the case on 7060 and 2700, passed. https://elastictest.org/scheduler/testplan/67808a9a572c09d3aa482375 https://elastictest.org/scheduler/testplan/67808b40745d47c6b42e53f4 https://elastictest.org/scheduler/testplan/67808bd3c66ca5ae0571bd57
202411 |
lipxu
added a commit
to lipxu/sonic-mgmt-lipxu-fork
that referenced
this pull request
Jan 13, 2025
…-net#16445) What is the motivation for this PR? Script log Analyzer timestamp is 2025-01-07 13:26:55.978427 while the real detect timestamp in syslog is Jan 7 13:27:18.132683. Need delay more time to grep the syslog 2025 Jan 7 13:26:55.996909 bjw2-can-7260-2 DEBUG extract_log combine_logs from file /var/log/syslog create time 2025-01-07 13:26:55.978427, size 4236007 syslog:23447:2025 Jan 7 13:27:18.132683 bjw2-can-7260-2 NOTICE swss#orchagent: :- report_pfc_storm: PFC Watchdog detected PFC storm on port Ethernet24, queue index 3, queue id 0x1500000000014d and port id 0x1000000000001 How did you do it? Increase the delay time and add some debug log in script How did you verify/test it? Use elastic to run the case on 7060 and 2700, passed. https://elastictest.org/scheduler/testplan/67808a9a572c09d3aa482375 https://elastictest.org/scheduler/testplan/67808b40745d47c6b42e53f4 https://elastictest.org/scheduler/testplan/67808bd3c66ca5ae0571bd57
202405 |
StormLiangMS
pushed a commit
that referenced
this pull request
Jan 15, 2025
… (#16492) What is the motivation for this PR? Script log Analyzer timestamp is 2025-01-07 13:26:55.978427 while the real detect timestamp in syslog is Jan 7 13:27:18.132683. Need delay more time to grep the syslog 2025 Jan 7 13:26:55.996909 bjw2-can-7260-2 DEBUG extract_log combine_logs from file /var/log/syslog create time 2025-01-07 13:26:55.978427, size 4236007 syslog:23447:2025 Jan 7 13:27:18.132683 bjw2-can-7260-2 NOTICE swss#orchagent: :- report_pfc_storm: PFC Watchdog detected PFC storm on port Ethernet24, queue index 3, queue id 0x1500000000014d and port id 0x1000000000001 How did you do it? Increase the delay time and add some debug log in script How did you verify/test it? Use elastic to run the case on 7060 and 2700, passed. https://elastictest.org/scheduler/testplan/67808a9a572c09d3aa482375 https://elastictest.org/scheduler/testplan/67808b40745d47c6b42e53f4 https://elastictest.org/scheduler/testplan/67808bd3c66ca5ae0571bd57
StormLiangMS
pushed a commit
that referenced
this pull request
Jan 15, 2025
… (#16493) What is the motivation for this PR? Script log Analyzer timestamp is 2025-01-07 13:26:55.978427 while the real detect timestamp in syslog is Jan 7 13:27:18.132683. Need delay more time to grep the syslog 2025 Jan 7 13:26:55.996909 bjw2-can-7260-2 DEBUG extract_log combine_logs from file /var/log/syslog create time 2025-01-07 13:26:55.978427, size 4236007 syslog:23447:2025 Jan 7 13:27:18.132683 bjw2-can-7260-2 NOTICE swss#orchagent: :- report_pfc_storm: PFC Watchdog detected PFC storm on port Ethernet24, queue index 3, queue id 0x1500000000014d and port id 0x1000000000001 How did you do it? Increase the delay time and add some debug log in script How did you verify/test it? Use elastic to run the case on 7060 and 2700, passed. https://elastictest.org/scheduler/testplan/67808a9a572c09d3aa482375 https://elastictest.org/scheduler/testplan/67808b40745d47c6b42e53f4 https://elastictest.org/scheduler/testplan/67808bd3c66ca5ae0571bd57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
29870655
Type of change
Back port request
Approach
What is the motivation for this PR?
Script log Analyzer timestamp is 2025-01-07 13:26:55.978427 while the real detect timestamp in syslog is Jan 7 13:27:18.132683.
Need delay more time to grep the syslog
2025 Jan 7 13:26:55.996909 bjw2-can-7260-2 DEBUG extract_log combine_logs from file /var/log/syslog create time 2025-01-07 13:26:55.978427, size 4236007
syslog:23447:2025 Jan 7 13:27:18.132683 bjw2-can-7260-2 NOTICE swss#orchagent: :- report_pfc_storm: PFC Watchdog detected PFC storm on port Ethernet24, queue index 3, queue id 0x1500000000014d and port id 0x1000000000001
How did you do it?
Increase the delay time and add some debug log in script
How did you verify/test it?
Use elastic to run the case on 7060 and 2700, passed.
https://elastictest.org/scheduler/testplan/67808a9a572c09d3aa482375
https://elastictest.org/scheduler/testplan/67808b40745d47c6b42e53f4
https://elastictest.org/scheduler/testplan/67808bd3c66ca5ae0571bd57
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation