Fix manage-config option comparison issue #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* If the option value of the kconfig-inclusions is a string with double quotes, remove it before value comparison to prevent failure.
|
are we expecting to have quote in the kconfig? why do you need to pass the quote? |
If there is no quote between the string, it will be come like this. The debian/build/build_amd64_none_amd64/.config can't correctly generated. It will become like |
paulmenzel
reviewed
Dec 17, 2020
|
If you added the example from the merge/pull request description to the commit message, that would be awesome. |
* Use parameter expression to remove the double quotes between the string value instead of using sed * This commit can fix following parsing error Originally, take CONFIG_MODULE_SIG_KEY="debian/certs/test.pem" in kconfig-inclusions for example, it will return error like this. ``` Checking added kernel options... Option CONFIG_MODULE_SIG_KEY should be set to ["debian/certs/test.pem"] instead of [debian/certs/test.pem] ``` If set string type value without quotes, CONFIG_MODULE_SIG_KEY=debian/certs/test.pem, it will also return error like this. ``` Checking added kernel options... Option CONFIG_MODULE_SIG_KEY should be set to [debian/certs/test.pem] instead of [] ```
|
/easycla |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make manage-config able to compare string type kernel options.
Use sed to remove the double quote at prefix and suffix of the option value if it exists.
Take
CONFIG_MODULE_SIG_KEY="debian/certs/test.pem"in kconfig-inclusions for example.Originally, if I give a kernel options with a double quoted string type value, it will return comparison failure.
After modification, it can pass the verification.