[dash-p4] Correctly set meta.dst_ip_addr for underlay routing lookup #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Commenter does not have sufficient privileges for PR 658 in repo sonic-net/DASH |
r12f
reviewed
Jan 14, 2025
| @@ -300,7 +300,12 @@ control dash_ingress( | |||
| routing_action_apply.apply(hdr, meta); | |||
|
|
|||
| /* Underlay routing */ | |||
| meta.dst_ip_addr = (bit<128>)hdr.u0_ipv4.dst_addr; | |||
| if (meta.routing_actions & dash_routing_actions_t.ENCAP_U1 != 0) { | |||
There was a problem hiding this comment.
Hi Junhua, do you mind to help add a small comment here that explains the dst_ip_addr will be used as key for underlay routing lookup?
There was a problem hiding this comment.
Updated the comment
|
/azp run |
|
Commenter does not have sufficient privileges for PR 658 in repo sonic-net/DASH |
r12f
approved these changes
Jan 15, 2025
|
Ok to merge per Community call 1/15/2025 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The key of underlay routing lookup is meta.dst_ip_addr. It should be updated to underlay destination IP only if underlay1/0 encapsulation is taken.