Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing Boilerplate License for legal compliance #409

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

fthobe
Copy link
Contributor

@fthobe fthobe commented Jan 29, 2025

Integrate correct copyright of 3rd party code used

Summary

Code used from https://github.com/mattbrictson/rails-template?tab=MIT-1-ov-file#readme
was not attributed correctly.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

Integrate correct copyright of 3rd party code used
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.00%. Comparing base (652caa6) to head (c27046b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #409   +/-   ##
=======================================
  Coverage   96.00%   96.00%           
=======================================
  Files         206      206           
  Lines        4901     4901           
=======================================
  Hits         4705     4705           
  Misses        196      196           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fthobe
Copy link
Contributor Author

fthobe commented Jan 29, 2025

@tvdeyen @kennyadsl @jarednorman is there anything else around in the code that is copied over you know of to attribute license?

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't

@tvdeyen tvdeyen merged commit 523f59e into solidusio:main Feb 5, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants